[FFmpeg-devel] [PATCH] Support uncompressed PCX scanlines

[Carl Eugen Hoyos]

Peter Ross <pross <at> xvid.org> writes:

> Sample here: http://roundup.ffmpeg.org/roundup/ffmpeg/issue1411

[...]

> +    if (encoding == 0) {

It should be (!encoding)

> +        memcpy(dst, src, bytes_per_scanline);
> +        src += bytes_per_scanline;
> +    } else {

And I believe I remember Michael saying once that he slightly prefers
if (condition) { //instead of if (!condition)
...
} else {
...
}

Apart from that, since Ivo did not send an email this month, I'd say just threat
to apply!

Carl Eugen