[FFmpeg-devel] [PATCH 06/12] WMA: use float_to_int16_interleave

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Sun, Sep 27, 2009 at 11:49:22AM +0100, Mans Rullgard wrote:
>> +    if (s->dsp.float_to_int16_interleave == ff_float_to_int16_interleave_c)
>> +        for (ch = 0; ch < s->nb_channels; ch++)
>> +            for (i = 0, iptr = s->frame_out[ch]; i < s->frame_len; i++, iptr++)
>> +                *iptr = *iptr / 32768.0f + 385.0f;
>> +    s->dsp.float_to_int16_interleave(samples, s->frame_out_ptr, s->frame_len,
>> +                                     s->nb_channels);
>
> This kind of code is a really mean thing and this would be the third
> place where it is added.
> Curiously aac and dca do not use that comparison, and the documentation
> for float_to_int16_interleave provides no explanation.
> Thus I'd like to request a cleanup/fixed documentation first, please :-)

I fully agree.  I have vague memories of attempting a discussion about
this in the past, obviously leading nowhere.

-- 
M?ns Rullg?rd
mans at mansr.com