[FFmpeg-devel] [PATCH][RFC] add a list of generic tag names

[Michael Niedermayer]

On Sat, Sep 26, 2009 at 12:25:27AM +0200, Anton Khirnov wrote:
> Hi,
> attached is a patch for $subj. Suggestions for new tags/renames are
> welcome, it'll also probably need some attention from the grammar
> na^W^Wenglish experts :)
> 
> year/date - the old code had 'year', but many formats support full date,
> so 'year' can be misleading. maybe there should be a separate 'year' tag
> and av_metadata_conv should be extended to automatically fill both.
> 
> Anton Khirnov

>  asf.c            |    4 ++--
>  avformat.h       |   22 +++++++++++++++++++++-
>  matroska.c       |    4 ++--
>  oggparsevorbis.c |    2 +-
>  4 files changed, 26 insertions(+), 6 deletions(-)
> adda244a4848b27d09238d112285be994a5a1ae3  0001-add-a-list-of-generic-tags.patch
> From a2558208fb6e283419e400f3d3e3f18c879de1db Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Fri, 25 Sep 2009 22:50:15 +0200
> Subject: [PATCH] add a list of generic tags and change demuxers to follow it.
> 
> ---
>  libavformat/asf.c            |    4 ++--
>  libavformat/avformat.h       |   22 +++++++++++++++++++++-
>  libavformat/matroska.c       |    4 ++--
>  libavformat/oggparsevorbis.c |    2 +-
>  4 files changed, 26 insertions(+), 6 deletions(-)
> 
> diff --git a/libavformat/asf.c b/libavformat/asf.c
> index 79ef614..8cf9655 100644
> --- a/libavformat/asf.c
> +++ b/libavformat/asf.c
> @@ -117,12 +117,12 @@ const ff_asf_guid ff_asf_language_guid = {
>  };
>  
>  const AVMetadataConv ff_asf_metadata_conv[] = {
> -    { "AlbumArtist", "artist"    },
> +    { "AlbumArtist", "albumauthor"},
>      { "AlbumTitle" , "album"     },
>      { "Author"     , "author"    },
>      { "Genre"      , "genre"     },
>      { "Copyright"  , "copyright" },
>      { "TrackNumber", "track"     },
> -    { "Year"       , "year"      },
> +    { "Year"       , "date"      },
>      { 0 }
>  };
> diff --git a/libavformat/avformat.h b/libavformat/avformat.h
> index be8c374..55f66d5 100644
> --- a/libavformat/avformat.h
> +++ b/libavformat/avformat.h
> @@ -99,7 +99,27 @@ int av_metadata_set(AVMetadata **pm, const char *key, const char *value);
>  
>  /**
>   * Converts all the metadata sets from ctx according to the source and
> - * destination conversion tables.
> + * destination conversion tables. If one of the tables is NULL, then
> + * tags are converted to/from ffmpeg generic tag names. Currently defined
> + * generic tag names are:
> + * album        -- name of the set this work belongs to
> + * albumauthor  -- main author of the set
> + * albumsort    -- used instead of album for sorting
> + * author       -- main author of the work
> + * authorsort   -- used instead of author for sorting
> + * comment      --
> + * composer     -- artist who composed the work, if different from author
> + * copyright    -- name of copyright holder
> + * date         -- date when the work was created, preferably in ISO 8601
> + * disc         -- number of a subset, i.e. disc in a multi-disc collection
> + * encoder      -- person who encoded the file
> + * genre        --
> + * language     --
> + * performer    -- artist who performed the work, if different from author
> + * publisher    --
> + * title        -- name of the work
> + * titlesort    -- used instead of title for sorting
> + * track        -- number of this work in the set

the *sort cases seem odd as they exist just for same, btw, which containers
use them?

Besides this your patch is fine in principle (some names might need
discussion and i would like to hear aurels oppinion of this as well ...)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090927/f7c30574/attachment.pgp>