[FFmpeg-devel] improved DV probe score patch BROKES detecting 1-frame DV

[Benjamin Larsson]

Reimar D?ffinger wrote:
> On Fri, Sep 25, 2009 at 11:48:55AM +0300, Maksym Veremeyenko wrote:
>   
>> I always thought that format detection for ffmpeg is prioritized in way:
>> 1. "-f <format>" input format redefinition
>> 2. input file extension
>> 3. stream probe
>> Why does it perform stream probe if input file extension is defined?
>>     
>
> No, no idea where you got that from.
> Extension does not matter for formats that have a probe function (which
> may be a bad idea), and for formats that do not have a probe function it
> sets the score to 50 (which seems a bit high to me).
>   

The file extension should just add to the score. Maybe not by 50 but at 
least something.

> Anyway, once more the MPEG detection strikes (if someone can find the
> motivation, extending probetest to check that no two probe functions
> return the same value even if <= 25 might be a good idea).
> Of course the DV probe function probably could be improved to reliably
> return a higher score for single-frame DVs, but that is a bit more
> effort :-).
> E.g. this change makes it work:
>   

MvH
Benjamin Larsson