[FFmpeg-devel] improved DV probe score patch BROKES detecting 1-frame DV

[Reimar Döffinger]

On Fri, Sep 25, 2009 at 02:43:51PM +0200, Michael Niedermayer wrote:
> On Fri, Sep 25, 2009 at 02:18:41PM +0200, Reimar D?ffinger wrote:
> > E.g. this change makes it work:
> > Index: libavformat/mpeg.c
> > ===================================================================
> > --- libavformat/mpeg.c  (revision 20013)
> > +++ libavformat/mpeg.c  (working copy)
> > @@ -78,7 +78,7 @@
> >  
> >  //av_log(NULL, AV_LOG_ERROR, "%d %d %d %d %d len:%d\n", sys, priv1,
> >  //pspack,vid, audio, p->buf_size);
> >      if(sys>invalid && sys*9 <= pspack*10)
> > -        return pspack > 2 ? AVPROBE_SCORE_MAX/2+2 : AVPROBE_SCORE_MAX/4; // +1 for .mpg
> > +        return pspack > 2 ? AVPROBE_SCORE_MAX/2+2 : AVPROBE_SCORE_MAX/4-1; // +1 for .mpg
> 
> i would prefer if the scores would not be decreased below 25 to workaround
> the inefficiency of the dv probe that we know how to improve.

Sorry to be snarky but I would prefer for the MPEG probe function not to
grab the world for itself, particularly since the DV probe probably
can't be much improved if you took just the first frame of pond.dv, so
while I don't feel like actually trying to do it, if you "combined" the
issues of pond.dv and this file you'd probably still have a file where
both formats return the same score.
Also I object to "that we know how to improve", I don't really know, I
always have to read up in our encoder source how things work :-) (but
yes, I am working on the DV probe, though I am not sure you will like my
approach).