[FFmpeg-devel] [PATCH] print message if probe failed due to probe conflict

[Michael Niedermayer]

On Fri, Sep 25, 2009 at 02:41:40PM +0200, Reimar D?ffinger wrote:
> On Fri, Sep 25, 2009 at 02:33:29PM +0200, Michael Niedermayer wrote:
> > On Fri, Sep 25, 2009 at 02:11:38PM +0200, Reimar D?ffinger wrote:
> > > If two probe functions return the same value, it is a bit hard to find
> > > out which ones were involved and broke things.
> > > So I propose this:
> > 
> > does your code work?
> > it looks to me like it would print a warning if 3 demuxers return
> > 1
> > 1
> > 90
> > but not if they return 
> > 1
> > 90
> > 1
> > 
> > simply printing all scores and piping through sort -n seems more usefull
> > to me in this case ...
> 
> It was not supposed to print anything in both cases, if forgot to check
> for fmt == NULL. I don't mean it as a test tool for conflicting probe
> values, but as an actually useful message for users, only for the case
> where probing actually fails.

Your code still does not look like it would work
especially as a user understandable warning because when probe fails the
probe buffer is increased until some limit, conflicts at > 25 can happen
and trigger your warning while in the next round probe can succeed without
conflict as one or more probes are than able to return more accurate
scores.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090925/c3435d31/attachment.pgp>