[FFmpeg-devel] [PATCH/RFC] Add some dsputil functions useful for AAC decoder

[Måns Rullgård]

Alex Converse <alex.converse at gmail.com> writes:

> On Fri, Sep 18, 2009 at 6:11 PM, Mans Rullgard <mans at mansr.com> wrote:
>> --- a/libavcodec/dsputil.h
>> +++ b/libavcodec/dsputil.h
>> @@ -397,6 +397,14 @@ typedef struct DSPContext {
>> ? ? /* assume len is a multiple of 8, and arrays are 16-byte aligned */
>> ? ? void (*int32_to_float_fmul_scalar)(float *dst, const int *src, float mul, int len);
>> ? ? void (*vector_clipf)(float *dst /* align 16 */, const float *src /* align 16 */, float min, float max, int len /* align 16 */);
>> + ? ?void (*vector_fmul_scalar)(float *dst, const float *src, float mul,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? int len);
>> + ? ?void (*vector_fmul_scalar_vp[2])(float *dst, const float *src,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? const float **vp, float mul, int len);
>> + ? ?void (*vp_fmul_scalar[2])(float *dst, const float **vp,
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?float mul, int len);
>> + ? ?float (*scalarproduct_float)(const float *v1, const float *v2, int len);
>> + ? ?void (*butterflies_float)(float *v1, float *v2, int len);
>>
>
> One last thought, do we want to tag anything restrict? I'm not sure
> all the places where these might be used so it's hard for me to guess
> but butterflies_float for instance looks like a good candidate for
> restrict.

Good point.  The other functions will be used with the output same as
one of the inputs at least in the AAC decoder.  I made them separate
arguments for added flexibility.

-- 
M?ns Rullg?rd
mans at mansr.com