[FFmpeg-devel] [PATCH 2/2] Move MDCT function pointers to MDCTContext

Michael Niedermayer michaelni
Fri Sep 18 15:17:28 CEST 2009


On Thu, Sep 17, 2009 at 12:51:06AM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Thu, Sep 17, 2009 at 12:33:11AM +0100, M?ns Rullg?rd wrote:
> >> Mans Rullgard <mans at mansr.com> writes:
> >> 
> >> > ---
> >> >  libavcodec/arm/fft_init_arm.c |    6 +++---
> >> >  libavcodec/dsputil.h          |   12 ++++++------
> >> >  libavcodec/mdct.c             |    6 +++---
> >> >  libavcodec/x86/fft.c          |   12 ++++++------
> >> >  4 files changed, 18 insertions(+), 18 deletions(-)
> >> 
> >> Ping.  What about this, assuming the first patch is OK?
> >
> > Its the first patch iam uncertain about
> > it does " 41 insertions(+), 14 deletions(-)"
> > which is it makes the code bigger and iam not sure what that is good
> > for ..
> 
> I thought it made sense in preparation for the patch I just sent,
> which will then be followed by another patch making the NEON MDCT a
> few % faster.  Feel free to suggest a better way.

what is the problem with just not spliting it?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090918/3515c79c/attachment.pgp>



More information about the ffmpeg-devel mailing list