[FFmpeg-devel] [PATCH] flush_put_bits_cache

[Sascha Sommer]

Hi,

On Sonntag, 13. September 2009, Michael Niedermayer wrote:
> On Sat, Aug 29, 2009 at 01:36:45PM +0200, Sascha Sommer wrote:
> > Hi,
> >
> > attached patch adds an alternate way of flushing the put bits buffer.
> > The new function makes it possible to access a put bits buffer till the
> > last bit without loosing the possibility to still append some more bits
> > at the position of the last write.
>
> why do we need 2 such functions with slightly different semantics?

We don't need both. The new function could be made the default for 
flush_put_bits. The old behaviour could be emulated by calling align_put_bits 
before flush_put_bits.

> why is it inline in a header? is it speed critical
>

The only reason it is inline in the header is that the other function was also 
declared like this.

Regards

Sascha