[FFmpeg-devel] [PATCH] OpenEXR decoder rev-16

[Jimmy Christensen]

On 2009-09-08 19:21, Diego Biurrun wrote:
> On Tue, Sep 08, 2009 at 03:30:26PM +0200, Jimmy Christensen wrote:
>>
>> --- libavcodec/exr.c	(revision 0)
>> +++ libavcodec/exr.c	(revision 0)
>> @@ -0,0 +1,469 @@
>> +static const unsigned int bytes_per_color_table[3] = {
>> +        1, 2, 4
>
> Indentation is off
>

Fixed in rev17.

>> +
>> +    if (channel_iter == s->red_channel ||
>> +        channel_iter == s->green_channel ||
>> +        channel_iter == s->blue_channel) {
>
> nit: align the ||

Fixed in rev17.

>
>> +                switch(*buf) {
>
> switch (
>

Fixed in rev17.

>> +    if (s->red_channel != -1&&
>> +        s->blue_channel != -1&&
>> +        s->green_channel != -1) {
>
> nit: align
>

Fixed in rev17.

Thanks for the review. Will post rev17 later.