[FFmpeg-devel] [PATCH] First shot at AVCHD seeking via new seeking API

Ivan Schreter schreter
Sun Sep 13 11:02:18 CEST 2009


Hi,

Michael Niedermayer wrote:
> On Sun, Sep 06, 2009 at 06:33:35PM +0200, Ivan Schreter wrote:
>   
>>> [...]  
>>>       
>> So like this, then:
>>
>> Index: libavformat/seek.c
>> ===================================================================
>> --- libavformat/seek.c  (revision 19788)
>> +++ libavformat/seek.c  (working copy)
>> @@ -342,8 +342,8 @@
>>
>>     // Find keyframes in all active streams with timestamp/position just 
>> before
>>     // and just after requested timestamp/position.
>> -    step = 1024;
>> -    curpos = pos;
>> +    step = s->pb->buffer_size;
>> +    curpos = FFMAX(pos - step / 2, 0);
>>     for (;;) {
>>         url_fseek(s->pb, curpos, SEEK_SET);
>>         search_hi_lo_keyframes(s,
>>
>> I also addressed the comment from Reimar regarding FFMAX.
>>
>>     

I've committed the change now.

>> I suppose, you are OK with me committing incremental improvements on 
>> seek.[ch] to svn, now that it's disabled?
>>     
>
> yes
>
>   

Thanks. I'll send some more patches in the next weeks to address your 
other comments.

Regards,

Ivan




More information about the ffmpeg-devel mailing list