[FFmpeg-devel] [PATCH] support for UTF-16 encoding in id3v2 tags

[Michael Niedermayer]

On Fri, Sep 11, 2009 at 10:33:37AM +0200, Anton Khirnov wrote:
> On Thu, Sep 10, 2009 at 01:07:17PM +0200, Michael Niedermayer wrote:
> > 
> > can be set before the switch() as default
> > 
> > 
> fixed
> > 
> > GET_16BIT not GET_BYTE
> > 
> fixed
> > 
> > missing error checking
> > 
> > unsigned int hi= val - 0xD800;
> > if(hi < 0x800) {
> >     val= get(s->pb) - 0xDC00;
> >     if(val > 0x3FFU || hi > 0x3FFU){
> >         ERROR
> >     }
> >     val+= (hi<<10) + 0x1000;
> > }
> > 
> fixed
> 
> 
> On Thu, Sep 10, 2009 at 01:58:57PM +0200, Reimar D?ffinger wrote:
> > 
> > Of course it should be
> > GET_16BIT, not get(s->pb).
> > _______________________________________________
> oops :) you're right of course, fixed.
> 
> Anton Khirnov

>  libavformat/id3v2.c |   28 ++++++++++++++++++++++++++++
>  libavutil/common.h  |   26 ++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
> 7b92620d0bf5540720a56bc7adb34b7d4f238543  0001-id3v2-add-support-for-UTF-16-encoding.patch
> From 2c8cb43ec213c2e604b133ab773aed03d22c1686 Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <wyskas at gmail.com>
> Date: Sun, 6 Sep 2009 13:34:48 +0200
> Subject: [PATCH] id3v2: add support for UTF-16 encoding.

ok if tested and reimar has no further comments

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090912/f836bec4/attachment.pgp>