[FFmpeg-devel] [PATCH] set bits_per_raw_sample when transcoding into wide colorspace

[Lars Täuber]

On Sat, 5 Sep 2009 10:07:23 +0200 Lars T?uber <lars.taeuber at gmx.net> wrote:
> On Sat, 5 Sep 2009 05:24:35 +0200 Michael Niedermayer <michaelni at gmx.at> wrote:
> > as you add a public function (av prefix & in public header) this would
> > need some justification why such public function makes sense,
> 
> The justification is that the pix_fmt_info is not directly accessible. Therefore a public function is needed. 
> There already is the indirect access to the pixfmt name through avcodec_get_pix_fmt inside ffmpeg.c that's why I thought it is the right way to access pix_fmt_info.
> 
> Btw. there should be public functions to read the other features of pix_fmt_info too. The other way I see is to move the definition and declaration from imgconvert.c into a header file.
> 
> > also it
> > would need to be better documented though some doxy should be there
> > either way ff_ or av_ ...
> > (the doxy also should say a word about rgb16 that have different depth
> >  for r/g/b)
> 

updated patch

Lars
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16bps.diff
Type: text/x-diff
Size: 1944 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090910/15f35b48/attachment.diff>