[FFmpeg-devel] [RFC] make sure $TMPE is executable

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> Hello,
> it seems that "GNU gold (GNU Binutils 2.19.1) 1.7" has a strange bug

What's that?

> where if the output file already exists and is not executable, it
> will stay not executable.
> This causes all check_exec calls to fail.
> Now since it _might_ be intended behaviour and since I am too lazy to
> report elsewhere, I wanted to ask if we should fix this in our
> configure, e.g. like this:

[...]

> Or like this:
> Index: configure
> ===================================================================
> --- configure   (revision 19808)
> +++ configure   (working copy)
> @@ -1489,6 +1489,7 @@
>
>  tmpfile TMPC  .c
>  tmpfile TMPE  $EXESUF
> +chmod +x $TMPE
>  tmpfile TMPH  .h
>  tmpfile TMPO  .o
>  tmpfile TMPS  .S

I prefer this, but with the chmod done after all the tmpfile calls.
It looks nicer that way.

On a related note, I find myself questioning the practice of executing
test files in the first place.  This obviously doesn't work when
cross-compiling, and we do support that.  Is there no other way to do
those tests that doesn't require executing files?

-- 
M?ns Rullg?rd
mans at mansr.com