[FFmpeg-devel] [PATCH] Store Major brand, Minor version and compatible brands of a mov file using the metadata API

Diego Biurrun diego
Wed Sep 9 12:49:03 CEST 2009


On Wed, Sep 09, 2009 at 01:42:17PM +0300, haim alon wrote:
> 
> It's my first patch so you can figure out why there are so much code style
> difference.

The rule is simple and applies everywhere: You have to adapt to the
local style, not the other way around.  You are just inserting a few
lines in a very long file.  They should not stick out like a sore thumb.

It's not just FFmpeg that works this way, it's basically everywhere.

> As far as I can see, the remaining style issue is just changing the variable
> names.

That and the 'else' placement...

> Thanks for your kindness feedback.

You are welcome.

Diego



More information about the ffmpeg-devel mailing list