[FFmpeg-devel] [PATCH] Store Major brand, Minor version and compatible brands of a mov file using the metadata API

haim alon haim.alter
Tue Sep 8 13:55:27 CEST 2009


Hi,

On Tue, Sep 8, 2009 at 11:54 AM, Diego Biurrun <diego at biurrun.de> wrote:

> On Mon, Sep 07, 2009 at 11:55:25AM +0300, haim alon wrote:
> >
> > --- libavformat/mov.c (revision 19787)
> > +++ libavformat/mov.c (working copy)
> > @@ -485,15 +485,41 @@
> >
> > +    for (i=0; i < numCompBrand; i++) { /*compatible brands*/
>
> nit: i = 0
>
>
Done.

Following Reimar's remark,  I also added a special check for the compatible
name string - if there is a NULL character, this brand is skipped and a
warning message is logged.

Attached an updated patch.

Thanks,
Haim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.compatible.patch
Type: text/x-patch
Size: 2652 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090908/9f795bf1/attachment.bin>



More information about the ffmpeg-devel mailing list