[FFmpeg-devel] [PATCH] ALS decoder

[Michael Niedermayer]

On Thu, Sep 03, 2009 at 08:27:19PM +0200, Reimar D?ffinger wrote:
> On Thu, Sep 03, 2009 at 08:19:24PM +0200, Diego Biurrun wrote:
> > On Thu, Sep 03, 2009 at 07:57:21PM +0200, Thilo Borgmann wrote:
> > > +#ifdef DEBUG
> > > +static av_cold void dprint_specific_config(ALSDecContext *ctx)
> > > +{
> > > +    AVCodecContext *avctx    = ctx->avctx;
> > > +    ALSSpecificConfig *sconf = &ctx->sconf;
> > > +
> > > +    dprintf(avctx, " num_frames = %i\n",          ctx->num_frames);
> > > +    dprintf(avctx, " last_frame_length = %i\n",   ctx->last_frame_length);
> > > +}
> > > +#endif
> > 
> > Wild idea: Maybe this could be an empty function if DEBUG is not set?
> 
> I actually would be quite in favour of making DEBUG 0/1 and doing
> if (!DEBUG)
>   return;
> 
> The reason: A lot of debug code in FFmpeg just doesn't compile anymore,
> doing it like this ensures the code will still be tested for compilation.

i like that idea ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090903/4d963567/attachment.pgp>