[FFmpeg-devel] [PATCH] mov reference files search improvement

[Diego Biurrun]

On Wed, Sep 02, 2009 at 02:56:38PM +0300, Maksym Veremeyenko wrote:
> Diego Biurrun ???????(??):
> >On Wed, Sep 02, 2009 at 01:26:11PM +0300, Maksym Veremeyenko wrote:
> >>Diego Biurrun ???????(??):
> >>>On Wed, Sep 02, 2009 at 09:55:32AM +0300, Maksym Veremeyenko wrote:
> [...]
> >>>>+        if(ref->directory_name)
> >>>if (
> >>>
> >>>more below
> >>fixed all *if* and *for* statements
> >
> >No.
> >
> >You put the { on the next line, keep it on the same.
> Sorry, i missed { position...

They're all fixed now, thanks.

> >>+    /* free aliases */
> >>+    for (i = 0; aliases[i] ; i++) av_free(aliases[i]);
> >
> >Put the statement on the next line, like everywhere else in this file.
> fixed?

Yes.

> newer patch attached.
> 
> --- libavformat/mov.c	(revision 19698)
> +++ libavformat/mov.c	(working copy)
> @@ -273,41 +273,72 @@
>  
> -                av_log(c->fc, AV_LOG_DEBUG, "type %d, len %d\n", type, len);
> +                av_log(c->fc, AV_LOG_DEBUG, "type %d, len %d\n",
> +                       type, len);

cosmetics

> +                } else if (type == 0) { // directory name

if (!type)

Diego