[FFmpeg-devel] [PATCH] mov reference files search improvement

[Maksym Veremeyenko]

Diego Biurrun ???????(??):
> On Wed, Sep 02, 2009 at 09:55:32AM +0300, Maksym Veremeyenko wrote:
>> --- libavformat/mov.c	(revision 19698)
>> +++ libavformat/mov.c	(working copy)
>> @@ -1513,6 +1538,115 @@
>>  
>> +    /* build relative */
>> +    if(ref->file_name)
>> +    {
> 
> if (ref->file_name) {
> 
fixed

>> +        /* find path */
>> +        pos = FFMAX(strrchr(filename, '/'), strrchr(filename, '\\'));
>> +        if(NULL == pos)
> 
> if (!pos)
fixed

> 
>> +        if(ref->directory_name)
> 
> if (
> 
> more below
fixed all *if* and *for* statements

> 
>> +        av_log(c->fc, AV_LOG_ERROR, "stream %d, alias not resolved, probed list [%s]\n",
>> +            idx, probed);
> 
> indentation
fixed

> 
> 
> You have some needlessly long lines in there that you could easily
> break.
> 
almost all been broken to avoid over 72 characters long lines

Updated patch attached.

-- 
________________________________________
Maksym Veremeyenko
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mov_refs_search_v3.patch
Type: text/x-patch
Size: 9461 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090902/2e816c58/attachment.bin>