[FFmpeg-devel] [PATCH] Add slicify filter

[Michael Niedermayer]

On Sat, Oct 31, 2009 at 12:26:59AM +0100, Stefano Sabatini wrote:
> On date Friday 2009-10-30 19:30:35 +0100, Diego Biurrun encoded:
> > On Fri, Oct 30, 2009 at 12:45:57PM +0100, Stefano Sabatini wrote:
> > > 
> > > --- ffmpeg.orig/doc/libavfilter.texi	2009-10-30 12:30:34.000000000 +0100
> > > +++ ffmpeg/doc/libavfilter.texi	2009-10-30 12:32:23.000000000 +0100
> > > @@ -174,6 +174,20 @@
> > >  
> > >  The default value of ``width'' and ``height'' is 0.
> > >  
> > > + at section slicify
> > > +
> > > +Pass the input video to next filter as multiple slices.
> > > +
> > > + at example
> > > +./ffmpeg -i in.avi -vfilters "slicify=32" out.avi
> > > + at end example
> > > +
> > > +The filter accepts as parameter the slice height (16 if not
> > > +specified).
> > 
> > The filter accepts the slice height as parameter
> 
> Fixed.
>  
> > > +Adding this in the beginning of filter chains should make filtering
> > > +faster due to the better use of the memory cache.
> > 
> > due to better use
> 
> Fixed.
>  
> > Your descriptions are improving.  Keep going.
> 
> To be honest, your fixes regarded the few parts I edited from the
> original description :-(...
> 
> > > --- ffmpeg.orig/libavfilter/allfilters.c	2009-10-30 12:29:59.000000000 +0100
> > > +++ ffmpeg/libavfilter/allfilters.c	2009-10-30 12:32:56.000000000 +0100
> > > @@ -39,5 +39,6 @@
> > >      REGISTER_FILTER (SCALE,scale,vf);
> > > +    REGISTER_FILTER (SLICIFY,slicify,vf);
> > >      REGISTER_FILTER (VFLIP,vflip,vf);
> > 
> > I insist that there should be spaces after the commas here.
> 
> I'll do that (globally) in a separate patch.
>  
> > > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > > +++ ffmpeg/libavfilter/vf_slicify.c	2009-10-30 12:45:40.000000000 +0100
> > > @@ -0,0 +1,102 @@
> > > +
> > > +/**
> > > + * @file libavfilter/vf_slicify.c
> > > + * slicing video filter
> > 
> > I'm unhappy with "slicing" but I'm at a loss to provide you a better
> > alternative... :-/
> 
> video slicing video filter -> video slicing [video] filter ->
> video slicing filter.
> 
> The second "video" can be omitted, since it's clear from the context,
> this is what suggested by Ben and also like in the original version by
> Bobby.
> 
> While at it I also changed the description of the filter to the
> original by Bobby:
> "Pass on input video to next video filter as multiple slices."
> 
> I also added a get_video_buffer() callback definition, which is not
> currently required, but it could be soon.
> 
> Regards.
> -- 
> FFmpeg = Furious Friendly Mystic Proud Elitist Generator

>  doc/libavfilter.texi     |   14 ++++++
>  libavfilter/Makefile     |    1 
>  libavfilter/allfilters.c |    1 
>  libavfilter/vf_slicify.c |  109 +++++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 125 insertions(+)
> c437e016d1bf76eb612090dfa9f6cda92f6fd597  add-slicify-filter.patch
> Index: ffmpeg/doc/libavfilter.texi
> ===================================================================
> --- ffmpeg.orig/doc/libavfilter.texi	2009-10-30 12:30:34.000000000 +0100
> +++ ffmpeg/doc/libavfilter.texi	2009-10-31 00:20:18.000000000 +0100
> @@ -174,6 +174,20 @@
>  
>  The default value of ``width'' and ``height'' is 0.
>  
> + at section slicify
> +
> +Pass on input video to next video filter as multiple slices.

its the images of the video that are split in slices, saying the
video is split sounds odd


> +
> + at example
> +./ffmpeg -i in.avi -vfilters "slicify=32" out.avi
> + at end example
> +
> +The filter accepts the slice height as parameter, if the parameter is
> +not specified it will use the default value of 16.
> +

> +Adding this in the beginning of filter chains should make filtering
> +faster due to better use of the memory cache.

Many decoders decode slicewise, avfilter should directly use these slices

anyway, the actual code should be ok, if (like always) this is extensively
tested in many combinations with other filters


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091031/a9e2ea3a/attachment.pgp>