[FFmpeg-devel] [PATCH] add initial suncc support

[Diego Biurrun]

On Wed, Oct 28, 2009 at 03:15:06PM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Wed, Oct 28, 2009 at 12:48:07PM +0100, Diego Biurrun wrote:
> >> On Tue, Oct 27, 2009 at 04:11:29AM +0300, Michael Kostylev wrote:
> >> > as in subject
> >> > 
> >> > --- ./configure.orig
> >> > +++ ./configure
> >> > @@ -1594,6 +1594,11 @@
> >> >      cc_version=__VERSION__
> >> >      CC_DEPFLAGS='-MMD'
> >> >      AS_DEPFLAGS='-MMD'
> >> > +elif $cc -V 2>&1 | grep -q Sun; then
> >> > +    cc_type=suncc
> >> > +    cc_version="AV_STRINGIFY(__SUNPRO_C)"
> >> > +    DEPEND_CMD='$(DEPCC) $(DEPFLAGS) $< | sed -e "1s,^.*: ,$@: ," -e "\$$!s,\$$, \\\\\\," -e "1!s,^.*: , ," > $(@:.o=.d)'
> >> > +    DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -xM1'
> >> 
> >> I think the DEPEND_CMD sed expression should be factorized out to
> >> accomodate other compilers better.  That's not really your job, however,
> >> and could well be done separately.
> >> 
> >> Oh, what do you mean by "initial support"?  Is this sufficient to
> >> compile with suncc?  If not, what is missing?
> >> 
> >> Otherwise the patch looks OK to me, Mans?
> >
> > Applied.
> 
> Why do you ask me for an opinion and then apply without waiting for an
> answer?

You replied to a later message in this thread already.  Given how
quickly you normally react I assumed you had nothing more to comment on.
If that was not the case, sorry.  Refactoring the dep commands is on my
todo for later today.  If there is anything else, say it...

Diego