[FFmpeg-devel] [PATCH] Make DECLARE_ALIGNED macros take array specifiers as separate argument

[Reimar Döffinger]

On Sun, Oct 18, 2009 at 04:41:09PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Sun, Oct 18, 2009 at 04:19:55PM +0100, Mans Rullgard wrote:
> >> The macro implementation might need the name of the variable being
> >> declared for compiler-specific syntax.  Adding an optional fourth
> >> argument allows us to pass the name and, if present, array specifiers
> >> as separate arguments.
> >
> > Could you be more specific on the syntax? If possible moving the
> > array specifiers just outside the DECLARE_ALIGNED would look nicer IMO.
> 
> I don't think that will work.  It certainly will not work with another
> patch I'm preparing.  What's so bad about this anyway?

Sorry, old thread.
Bad things about it:
1) I think it looks quite ugly
2) except for DEBUG stuff it would be the first/only use of vararg macros, no
idea how well they are supported, though at least MPlayer uses the ##args syntax
for gcc, so __VA_ARGS__ might not work e.g. with 2.95?