[FFmpeg-devel] [PATCH] remove pnm code cruft

Diego Biurrun diego
Tue Oct 27 13:58:53 CET 2009


On Tue, Oct 27, 2009 at 01:49:42PM +0100, Michael Niedermayer wrote:
> On Tue, Oct 27, 2009 at 10:44:12AM +0000, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Tue, Oct 27, 2009 at 11:06:03AM +0100, Diego Biurrun wrote:
> > >> This removes some cruft from pnmenc.c.  I intend to split the file
> > >> afterwards, so removing cruft seems like a good first step.
> > >
> > > instead of removing the probe code, the code should be used
> > 
> > That code is a remnant from when this file was in lavf.
> 
> yes
> 
> >  It should be deleted.
> 
> no
> Id like to have functioning image2 probing.

I'd like to have a pony.

> This code should be exported from the decoder (AVCodec.probe maybe)
> and then img2.c image_probe() should call that for all image codecs
> for probing instead of pure filename extension based probing.

Do it.  If you haven't done it by next week, I will just delete the
non-compiling cruft, since it will never be used nor repaired.

Diego



More information about the ffmpeg-devel mailing list