[FFmpeg-devel] PATCH rtsp/sdp/multicast

[Diego Biurrun]

On Fri, Oct 23, 2009 at 03:48:37AM +0200, armand bendanan wrote:
> 
> > On Wed, Oct 21, 2009 at 10:03:03PM +0200, armand bendanan wrote:
> > >
> > > --- old/libavformat/rtsp.c	2009-10-21 19:47:39.000000000 +0200
> > > +++ ffmpeg/libavformat/rtsp.c	2009-10-21 20:06:59.000000000 +0200
> > > @@ -1125,12 +1125,24 @@
> > >                  char url[1024];
> > >                  struct in_addr in;
> > > +                int port;
> > > +                int ttl;
> > 
> > Merge this into one line.
> > 
> > > +            		port = reply->transports[0].port_min;
> > > +            		ttl = reply->transports[0].ttl;
> > 
> > The '=' could be aligned.
> > 
> > > +            		in = rtsp_st->sdp_ip;
> > > +            		port = rtsp_st->sdp_port;
> > > +            		ttl = rtsp_st->sdp_ttl;
> > 
> > same here
> > 
> > >                  snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
> > >                           inet_ntoa(in),
> > > -                         reply->transports[0].port_min,
> > > -                         reply->transports[0].ttl);
> > > +                         port,
> > > +                         ttl);
> > 
> > shorter:
> > 
> >   snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
> >            inet_ntoa(in), port, ttl);
> > 
> > Also, get rid of all the tabs.
> 
> Here is the new corrected patch.

I would hardly call it that.  You addressed at most half of the issues I
pointed out.

Diego