[FFmpeg-devel] [PATCH] Add support for lavfi filter long names

[Stefano Sabatini]

On date Wednesday 2009-10-21 14:54:04 +0200, Diego Biurrun encoded:
> On Wed, Oct 21, 2009 at 12:39:12AM +0200, Stefano Sabatini wrote:
> > On date Tuesday 2009-10-20 01:20:38 +0200, Michael Niedermayer encoded:
> > > On Mon, Oct 19, 2009 at 09:25:20PM +0200, Stefano Sabatini wrote:
> > > > --- libavfilter/avfilter.h	(revision 20314)
> > > > +++ libavfilter/avfilter.h	(working copy)
> > > > @@ -426,6 +426,12 @@
> > > >  
> > > > +    /**
> > > > +     * Descriptive name for the filter. You should use the
> > > > +     * NULL_IF_CONFIG_SMALL() macro to define it.
> > > > +     */
> > > > +    const char *long_name;
> > > 
> > > somthing tells me that description would be better than long_name
> > > like in "(Filter that )flips the given image vertically"
> > 
> > Absolutely, patch updated.
> 
> Wouldn't that argument apply to libavcodec as well?

Maybe, we could use to contain the small descriptions in general.texi.

But then most formats are documented somewhere (for example in the
multimedia wiki), so the name of a format is usually sufficient to
describe what a format is, the same can't be said for a filter, as
they are internal to the project.

But then again I have no strong opinion and someone may argue that
this would just bloat the code.

Regards.
-- 
FFmpeg = Fiendish and Fast Magical Peaceless Elitist Gospel