[FFmpeg-devel] [PATCH] seek print NOPTS

[Ramiro Polla]

Hi,

Calm down, this is not worth flaming for...

On Tue, Oct 20, 2009 at 4:24 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> Are you sure you read that thread really? Because I feel I must have read
> something else...
>
> On Tue, Oct 20, 2009 at 11:17:53AM -0700, Baptiste Coudurier wrote:
>> Quoting Reimar:
>> "Uh.. could you please explain the sense behind that? Because like this,
>> you complicate the code _and_ it is just wrong..."
>
> You are quoting me out of context. That was the response to just printing
> -1. While personally I think that the previous handling of AV_NOPTS_VALUE
> was wrong/a bad idea, too, -1 can reasonably appear in the output and thus
> printing -1 for AV_NOPTS_VALUE is just wrong IMO.

Indeed, that patch was just wrong.

>> Now changing to NOPTS is ok for cosmetics reason ? And you guys
>> couldn't suggest that in the first place ?
>
> Michael did suggest something like I ended up doing in one

And I didn't follow up since it was already "fixed" in mingw
(ironically like Mans's suggestion). Reimar did something similar to
Michael's suggestion and the patch was applied...

But it's true around here that mentioning "Windows" anywhere blinds
everyone into thinking patches are worthless, even if the issue was
just discovered on Windows and is also reproducible on Linux, and even
if the patch has more uses than just fixing an issue on Windows.

Anyways the patch is in already, there's no reason to continue this thread...

Ramiro Polla