[FFmpeg-devel] Patch: remove useless SHIFT_TEMPS definition

Benoit Fouet benoit.fouet
Tue Oct 20 13:24:04 CEST 2009


On Tue, 20 Oct 2009 10:24:28 +0200 Michael Niedermayer wrote:
> On Tue, Oct 20, 2009 at 02:29:05PM +0800, avcoder wrote:
> > Dear:
> > SHIFT_TEMPS marco definition in jfdctfst.c and jfdctint.c is useless
> > 
> > The following patches remove them
> 
> ok, but id like to say that such patches are normally unacceptable without
> the patch submitter explaining more elaborately what the removed code was
> good for and why this no longer applies.
> 

Applied...

> Your patch here is the kind of "remove it because i dont understand it
> and it makes no immedeate differenece"
> 
> Ill fill in the needed explaination here, i wont do it again though.
> 

... and I added the thread name, so that people can find your (wonderful)
explanation, should they need it ;)

Ben



More information about the ffmpeg-devel mailing list