[FFmpeg-devel] [PATCH] Move eval to lavu

[Michael Niedermayer]

On Tue, Oct 20, 2009 at 12:29:25PM +0200, Stefano Sabatini wrote:
> On date Tuesday 2009-10-20 12:03:34 +0200, Michael Niedermayer encoded:
> > On Tue, Oct 20, 2009 at 09:38:54AM +0100, M?ns Rullg?rd wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
> > > 
> > > > On Mon, Oct 19, 2009 at 08:58:58PM +0200, Stefano Sabatini wrote:
> > > >> Hi,
> > > >> 
> > > >> as in subject, this doesn't comport any external interface change
> > > >> since eval.h is not public, and libavutil seems the right place for
> > > >> the eval code.
> > > >
> > > > if eval.h is not public then eval can not be used from outside the lib
> > > > in which eval is. That makes it impossible for libavcodec to use it.
> > > > Your patch is clearly broken in this respect as libavcodec then uses
> > > > non public API from libavutil
> > > 
> > > How about making it public?
> > 
> > thats possible, but it requires the API to be carefully reviewed first
> > and that review might find things that require changes ...
> > also it seems alot of work without an advantage being stated first,
> > does some application want to use the eval code?
> 
> We could move it to lavu and state in the doxy that it is not intended
> to be used outside FFmpeg, that would be similar for example to the
> situation for av_log_missing_feature().

that has no point, we still would have to bump lavu&lavc major versions
if we change the API/ABI in an incompatible way


> 
> For example lavfi may use it, and it's not still clear to me if you
> want to avoid to make lavfi depend on lavc (actually it depends on
> it).

i would prefer to avoid dependancies between libs where possible


> 
> IMHO anyway lavu is the place for the eval code.

maybe, but it could become quite a bit of work
especially i would prefer if lavfi work is not delayed by it, eval
is not essential for lavfi ATM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When the tyrant has disposed of foreign enemies by conquest or treaty, and
there is nothing more to fear from them, then he is always stirring up
some war or other, in order that the people may require a leader. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091020/9d87dca6/attachment.pgp>