[FFmpeg-devel] [PATCH] Move eval to lavu

[Stefano Sabatini]

On date Tuesday 2009-10-20 12:03:34 +0200, Michael Niedermayer encoded:
> On Tue, Oct 20, 2009 at 09:38:54AM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > On Mon, Oct 19, 2009 at 08:58:58PM +0200, Stefano Sabatini wrote:
> > >> Hi,
> > >> 
> > >> as in subject, this doesn't comport any external interface change
> > >> since eval.h is not public, and libavutil seems the right place for
> > >> the eval code.
> > >
> > > if eval.h is not public then eval can not be used from outside the lib
> > > in which eval is. That makes it impossible for libavcodec to use it.
> > > Your patch is clearly broken in this respect as libavcodec then uses
> > > non public API from libavutil
> > 
> > How about making it public?
> 
> thats possible, but it requires the API to be carefully reviewed first
> and that review might find things that require changes ...
> also it seems alot of work without an advantage being stated first,
> does some application want to use the eval code?

We could move it to lavu and state in the doxy that it is not intended
to be used outside FFmpeg, that would be similar for example to the
situation for av_log_missing_feature().

For example lavfi may use it, and it's not still clear to me if you
want to avoid to make lavfi depend on lavc (actually it depends on
it).

IMHO anyway lavu is the place for the eval code.

Regards.
-- 
FFmpeg = Free and Fantastic Mystic Portable Educated Gadget