[FFmpeg-devel] [PATCH] Implement avfilter_make_format_list2(enum PixelFormat pix_fmt, ...)

[Stefano Sabatini]

On date Sunday 2009-10-18 01:13:34 +0200, Michael Niedermayer encoded:
> On Sun, Oct 18, 2009 at 12:00:59AM +0200, Stefano Sabatini wrote:
[...]
> > Index: ffmpeg-vfilters/ffmpeg/libavfilter/formats.c
> > ===================================================================
> > --- ffmpeg-vfilters.orig/ffmpeg/libavfilter/formats.c	2009-10-17 23:46:40.000000000 +0200
> > +++ ffmpeg-vfilters/ffmpeg/libavfilter/formats.c	2009-10-17 23:47:13.000000000 +0200
> > @@ -87,6 +87,23 @@
> >      return ret;
> >  }
> >  
> > +AVFilterFormats *avfilter_make_format_list2(enum PixelFormat *pix_fmt)
> > +{
> > +    AVFilterFormats *formats;
> > +    int count;
> 
> > +    enum PixelFormat *p;
> > +
> > +    for (count = 0, p = pix_fmt; *p != PIX_FMT_NONE; p++, count++)
> > +        ;
> 
> too many ; and , on one line (unreadable)
> i suggest:
> 
> for(i=0; pix_fmt[i]; i++)
>     ;

Yes. BTW, what should we do with the old function, I mean should we
deprecate it?

Regards.
-- 
FFmpeg = Frightening & Fast Mastodontic Picky Ecstatic God
-------------- next part --------------
A non-text attachment was scrubbed...
Name: implement-make-format-list2.patch
Type: text/x-diff
Size: 1722 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091018/8581c2ca/attachment.patch>