[FFmpeg-devel] [PATCH] use strings for error return values in seek_test

[Michael Niedermayer]

On Fri, Oct 16, 2009 at 04:12:19PM +0200, Reimar D?ffinger wrote:
> On Fri, Oct 02, 2009 at 08:58:07PM +0200, Michael Niedermayer wrote:
> > On Fri, Oct 02, 2009 at 02:38:06PM +0200, Reimar D?ffinger wrote:
> > > Note that it is still aligned for 0 and -1, and most of the error cases (IMO all
> > > except those that are broken) only print this ret: part (and they were aligned before).
> > > Apart from that it should be only a matter of changing %s to e.g. %-10s, but that would
> > 
> > > 1) make the already long lines even longer
> > 
> > theres alot that can be droped to make them shorter (the -E comes to mind)
> > 
> > 
> > > 2) it will change _all_ the lines in the regressions file
> > > I don't mind changing it, the effort is minimal but due to 2) it should be at least
> > > in a separate patch.
> > 
> > of course
> 
> I wanted to apply this, but wanted to maybe get a quick comment if you
> really think shortening the error names (losing some of the better
> readability) and/or alignment really seems necessary or even useful to
> you.

i think makeing the whole list aligned is usefull, about the -E i agree
that its nicer if that stays ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091017/b949cc0a/attachment.pgp>