[FFmpeg-devel] [PATCH] hardcoded ff_cos tables

[Reimar Döffinger]

On Wed, Oct 14, 2009 at 09:35:08PM +0100, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > On Wed, Oct 14, 2009 at 07:15:58PM +0200, Reimar D?ffinger wrote:
> >> > As for the need, everything with external linkage should be
> >> > declared in some header IMHO.  Furthermore, someone might want to use
> >> > those tables from C code too, not just asm.
> >> 
> >> Which is a completely unrelated, already existing mess.
> >> And no, I can't see a reason to use those tables from C code, that's
> 
> Same reason as using it from asm...
> 
> >> what ff_cos_tab is there for (and it _might_ even make sense to use it
> >> from asm code).
> 
> That would be slower.

I'm unconvinced you'd get any consistent results unless you used asm.

> > This patch should demonstrate it is an independent issue, it needs no
> > extra header file and eliminates a good bit of code duplication.
> 
> I fail to see how this patch demonstrates anything related to that
> issue.  There are still external symbols with no declaration in a
> header file.  On the contrary, you now have symbols referenced in
> multiple places with no common declaration.  This is *always* a bad
> thing.

Huh? The symbols are not referenced in any more places than before.
Any missing declarations have nothing to do with this patch,
and where to put them etc. is going to be a highly bikeshed topic
and thus I'd highly appreciate it if I didn't have to go through
that first.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: costable.diff
Type: text/x-diff
Size: 5483 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091014/7cc525d0/attachment.diff>