[FFmpeg-devel] [PATCH] Implement libavcodec/opt.[ch] generic options handling

Michael Niedermayer michaelni
Tue Oct 13 12:04:01 CEST 2009


On Tue, Oct 13, 2009 at 01:58:24AM +0200, Stefano Sabatini wrote:
[...]
> } AVOption2;
> 
> Would be that an acceptable move towards an acceptable solution?

honestly this all is very messy
maybe we can just repace default_val by an union of double and char* and add
a flag to indicate that its a char*, this with some luck should maintain
compaibility.

and i do not see why a overrideable set_string() would make sense
add your code to the existing set_string()


> 
> Having just a set_string handler and a string with the default value
> (as opposed to my idea of using also a set_default_value() handler)
> looks like a good idea.
> 

> Still I miss how would be possible to pass some parameters (e.g. min,
> max, offset1, offset2) to a specific option, you somehow disliked my
> idea of using an opaque field for that.

i dont understand what you want to do with set_string() here?


> 
> An alternative solution may be to have something like this:
> 
>    int (*set_string)(void *ctx, const char *params, const char *val);
> 
> where params is a string with a list of parameters which are defined
> like this: "min=32:max=64".

i dont understand what this is supposed to be


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091013/8cd2d6cb/attachment.pgp>



More information about the ffmpeg-devel mailing list