[FFmpeg-devel] [PATCH]Fix one icc warning

Carl Eugen Hoyos cehoyos
Sun Oct 11 13:46:00 CEST 2009


M?ns Rullg?rd <mans <at> mansr.com> writes:

> > Index: libavformat/utils.c
> > ===================================================================
> > --- libavformat/utils.c	(revision 20108)
> > +++ libavformat/utils.c	(working copy)
> > @@ -1594,7 +1594,7 @@
> >  
> >      //Fallback to old API if new is not implemented but old is
> >      //Note the old has somewat different sematics
> > -    if(s->iformat->read_seek || 1)
> > +    if(1 || s->iformat->read_seek)
> >          return av_seek_frame(s, stream_index, ts, flags | (ts - min_ts >
> > (uint64_t)(max_ts - ts) ?
> AVSEEK_FLAG_BACKWARD : 0));
> 
> WTF is this?  What's the purpose of the obfuscation, and why does it
> matter to the compiler?

I really cannot comment on these questions, I only know that there is a warning
when this functions is compiled with icc (but not gcc) and that the change (that
does not change behaviour, afaict) fixes the warning.
iirc, we agreed that less useless warnings are an improvement.

Carl Eugen

http://fate.multimedia.cx/index.php?stderr=121511
(First line)







More information about the ffmpeg-devel mailing list