[FFmpeg-devel] [PATCH]Allow decoding of eac3 in mpegts

[Carl Eugen Hoyos]

Baptiste Coudurier <baptiste.coudurier <at> gmail.com> writes:

> >> We might also want to probe it sucessfully.
> >>
> >> Can you please test that set_codec_from_probe_data returns eac3 raw
> >> demuxer ? It could then be enabled.
> >
> > Sorry, I don't understand: The eac3 raw muxer and demuxer work fine with
> > this sample (but that was probably not what you meant).
> >
> 
> Technically, the codec id is set to CODEC_ID_PROBE, to enable codec 
> autodetection due to the many private streams in ts. The codec probing 
> system should probe correctly EAC3 ideally, however it seems that the 
> raw eac3 demuxer is not checked against in set_codec_from_probe_data, I 
> was wondering if adding it would make the codec sucessfully probed.

Thank you for the explanation (that also explains why we do not need those many
ID's proposed once).

> I hope it more clear :)

;-)

So should I revert r20200 and apply the following (inlined) that also fixes the
one Depending substream sample we have (with score 51)?

Carl Eugen

Index: libavformat/utils.c
===================================================================
--- libavformat/utils.c (revision 20202)
+++ libavformat/utils.c (working copy)
@@ -329,6 +329,9 @@
         } else if (!strcmp(fmt->name, "ac3")) {
             st->codec->codec_id = CODEC_ID_AC3;
             st->codec->codec_type = CODEC_TYPE_AUDIO;
+        } else if (!strcmp(fmt->name, "eac3")) {
+            st->codec->codec_id = CODEC_ID_EAC3;
+            st->codec->codec_type = CODEC_TYPE_AUDIO;
         } else if (!strcmp(fmt->name, "mpegvideo")) {
             st->codec->codec_id = CODEC_ID_MPEG2VIDEO;
             st->codec->codec_type = CODEC_TYPE_VIDEO;