[FFmpeg-devel] [HOWTO] Building FFmpeg for iPhone

David Conrad lessen42
Thu Oct 8 16:40:31 CEST 2009


On Oct 8, 2009, at 9:45 AM, M?ns Rullg?rd wrote:

> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>
>> On Thu, Oct 08, 2009 at 12:03:57PM +0100, M?ns Rullg?rd wrote:
>>> David Conrad <lessen42 at gmail.com> writes:
>>>
>>>> On Oct 7, 2009, at 10:07 AM, Jason Millard wrote:
>>>>
>>>>> --arch=arm --extra-cflags='-arch armv6' --extra-ldflags='-arch  
>>>>> armv6'
>>>>> Thanks. that did the trick. With my tests, mp3 decoding is fine,  
>>>>> but
>>>>> aac
>>>>> decoding is mostly static -- (almost like the volume is amplified)
>>>>
>>>> Reproduced, it's because the aac and dca decoders check for the C
>>>> version of float_to_int16 but use float_to_int16_interleave, which
>>>> doesn't have a VFP version.
>>>>
>>>> Patch attached
>
> [...]
>
>>> The idea of checking those functions like that is dreadful, but this
>>> doesn't make it any worse, and it does fix a bug.  I say apply.
>>
>> Maybe those values (385.0f, 1.0 / 32768.0) should just be added to
>> the DspContext?  Of course that depends on what sf_offset is and
>> what its meaning is...
>
> Yes, that would be better, but this issue always decays into
> bikeshedding, so just commit the fix already.  Fixing this bug is a
> separate issue from fixing the design.

Applied.



More information about the ffmpeg-devel mailing list