[FFmpeg-devel] [PATCH] libavfilter-soc: add some regression tests

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

> On Mon, Oct 05, 2009 at 10:50:01PM +0200, Stefano Sabatini wrote:
>> On date Monday 2009-10-05 04:43:53 +0200, Diego Biurrun encoded:
>> > On Sat, Oct 03, 2009 at 11:27:09AM +0200, Stefano Sabatini wrote:
>> > > Hi, this patch adds some regression tests to lavfi.
>> > > 
>> > > --- tests/codec-regression.sh	(revision 20088)
>> > > +++ tests/codec-regression.sh	(working copy)
>> > > @@ -672,10 +672,15 @@
>> > >  
>> > > -# example tests:
>> > > -# do_lavfi "crop" "crop=100:100:-1:-1"
>> > > -# do_lavfi "crop_scale" "crop=100:100,scale=200:-1"
>> > > -# do_lavfi "scale" "scale=200:200"
>> > > +do_lavfi "null" "null"
>> > > +do_lavfi "crop" "crop=100:100:-1:-1"
>> > > +do_lavfi "crop_scale" "crop=100:100,scale=200:-1"
>> > > +do_lavfi "crop_vflip" "crop=100:100,vflip"
>> > > +do_lavfi "scale200" "scale=200:200"
>> > > +do_lavfi "scale500" "scale=500:500"
>> > > +do_lavfi "vflip" "vflip"
>> > > +do_lavfi "vflip_crop" "vflip,crop=100:100"
>> > > +do_lavfi "vflip_vflip" "vflip,vflip"
>> > 
>> > Maybe put this into a separate lavfi regression test script?
>> 
>> Like in attached?
>
> Something like that, yes.  Note that I haven't looked at it in detail
> yet.
>
>> Do you think would be possible to put the code shared with
>> codec-regression.sh (e.g. do_ffmpeg, do_video_encoding) in a common
>> file?
>
> Yes, that was the idea I was entertaining.  Mans?

Not a bad idea.  I'd move the shared bits into a regression-funcs.sh
file and . that from the other files.

-- 
M?ns Rullg?rd
mans at mansr.com