[FFmpeg-devel] [PATCH] libavfilter-soc: implement pad filter

Stefano Sabatini stefano.sabatini-lala
Sat Oct 3 11:37:58 CEST 2009


On date Saturday 2009-10-03 04:47:12 +0200, Michael Niedermayer encoded:
> On Sat, Oct 03, 2009 at 03:58:05AM +0200, Michael Niedermayer wrote:
> [...]
> > also i like to repeat what i said many times, libavfilter MUST be moved
> > into main svn as soon as possible
> 
> and id like to underline this again, people should pick a file and try to
> move that into main svn. Issues in that can be dealt with during review
> iterations. What we have is that main svn, soc svn and your private avfilter
> all differ, each change that makes them differ more will be VERY painfull
> to people working on the code. [expect lots of absolutely required code
> splits, redesigns and rewrites once it hits actual review, thus the more
> time that is invested into this outside of proper review the more painfull it
> will be once the mistakes are found that inevitable will be in there,
> avfilter is very complex, it wont be free of issues ...]
> 
> We move much more in circles than ahead currently with avfilter
> 
> If you wish to add parameters to get_video_buffer() that should be in
> form of a patch against main svn with explanations why such parameters
> are needed.

I'm discussing the changes to the get_video_buffer() system because
they're intimately connected to how the pad filter works, but if you
prefer I'll discuss them separately.

My current plan is:

* to get the get_video_buffer() change committed to the main repo
  (that would require a major bump in lavfi version numbers, that
  shouldn't be a problem as currently no one in the workd is likely
  still using lavfi)

* to get the pad, crop, scale filters in the main repo and add some
  tests for them

* to implement variable frame size support

During this process some things things may go meaningwhile in the soc
repo, for example some regression tests may be useful to let people
(which is now pratically just me) test the changes to the API.

Regards.
-- 
FFmpeg = Faithless and Fast Martial Peaceless EniGma



More information about the ffmpeg-devel mailing list