[FFmpeg-devel] [PATCH] Fix pcm_read_seek for positions larger than 2 GB

Michael Niedermayer michaelni
Fri Oct 2 12:20:31 CEST 2009


On Thu, Oct 01, 2009 at 07:32:00PM -0500, Daniel Verkamp wrote:
> Hi,
> 
> Attached is a patch to fix pcm_read_seek() when the position it
> calculates is greater than 2 GB.
> 
> Currently, it puts the return value of url_fseek() in an int and then
> compares < 0 to see if an error occurred; if the position is greater
> than 2 GB, the 32-bit signed int result will be < 0.
> 
> The patch just changes the type of ret to int64_t to avoid the wraparound.
> 
> This fixes seeking of large audio files; tested in ffplay with a ~4 GB
> RF64 file and a ~8GB SoX file.
> 
> Thanks,
> -- Daniel Verkamp

> From 7312cd64b2aadd704f0f501b8e65c32dc66fc05b Mon Sep 17 00:00:00 2001
> From: Daniel Verkamp <daniel at drv.nu>
> Date: Thu, 1 Oct 2009 20:27:35 -0400
> Subject: [PATCH] Fix pcm_read_seek for positions larger than 2 GB

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091002/01181e2f/attachment.pgp>



More information about the ffmpeg-devel mailing list