[FFmpeg-devel] [PATCH] Add pad filter

[Stefano Sabatini]

On date Monday 2009-11-30 01:28:41 +0100, Michael Niedermayer encoded:
> On Sun, Nov 29, 2009 at 02:13:51AM +0100, Stefano Sabatini wrote:
> > On date Friday 2009-11-27 02:42:59 +0100, Michael Niedermayer encoded:
> > > On Fri, Nov 27, 2009 at 01:09:28AM +0100, Stefano Sabatini wrote:
[...]
> > > > +    y1 = y == 0 ? 0 : y + pad->y;
> > > > +    h1 = h;
> > > > +    if (y == 0)
> > > > +        h1 += pad->y;
> > > > +    if (y+h >= link->h)
> > > > +        h1 += pad->h - pad->y - link->h;
> > > > +
> > > > +    avfilter_draw_slice(link->dst->outputs[0], y1, h1);
> > > 
> > > this draw slice behaves quite odd, i would have expectd that slices didnt grow
> > 
> > Also this was wrong as it was misbehaving when in combination with
> > vflip, since the slices direction order wasn't respected.
> > 
> > Now the filter sends slices with dimension not greater than those of
> > the input slice, and keeps in consideration the slices direction (which
> > unfortunately complicates the code).
> 
> i think the code is too complex and messy now for what it does.
> Also it now partly duplicates slicify 

What about to issue just a single slice for the top and bottom bars?
Then the user may manually add a slicify filter for decreasing the
size of the top/bottom bars if she cares, that should greatly simplify
the code.

Regards.
-- 
FFmpeg = Fundamentalist & Furious Merciful Portable EnGine