[FFmpeg-devel] [PATCH] Rename put_sbit() params

[Stefano Sabatini]

On date Sunday 2009-11-29 13:20:40 +0100, Michael Niedermayer encoded:
> On Sun, Nov 29, 2009 at 10:51:36AM +0100, Stefano Sabatini wrote:
> > On date Saturday 2009-11-28 12:05:37 +0100, Michael Niedermayer encoded:
> > > On Sat, Nov 28, 2009 at 11:43:34AM +0100, Stefano Sabatini wrote:
> > > > On date Saturday 2009-04-11 12:05:32 +0200, Stefano Sabatini encoded:
> > > > > Hi,
> > > > > 
> > > > > this should make more apparent the similarities between put_bits() and
> > > > > put_sbits().
> > > > > 
> > > > > Decrease the user sense of wonder when reading the declaration.
> > > > 
> > > > Patch updated.
> > > > -- 
> > > > FFmpeg = Foolish and Fundamentalist Magic Philosofic Extreme Glue
> > > 
> > > >  put_bits.h |    6 +++---
> > > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > > b0bf9d0b47ef3c8b818a2fb49b62ab5caa2ab830  bs-rename-put-sbits-params.patch
> > > > Index: ffmpeg/libavcodec/put_bits.h
> > > > ===================================================================
> > > > --- ffmpeg.orig/libavcodec/put_bits.h	2009-11-28 11:40:12.000000000 +0100
> > > > +++ ffmpeg/libavcodec/put_bits.h	2009-11-28 11:40:52.000000000 +0100
> > > > @@ -257,11 +257,11 @@
> > > >  }
> > > >  #endif
> > > >  
> > > > -static inline void put_sbits(PutBitContext *pb, int bits, int32_t val)
> > > > +static inline void put_sbits(PutBitContext *s, int n, int32_t value)
> > > 
> > > pb is better than s
> > 
> > I agree, but then all the other functions use 's' for the putbit
> > context, would be to change them globally be an option? (I suppose
> > that is overkill).
> 
> i also think its overkill, thats no reason to change it to the worse though

Updated.
-- 
FFmpeg = Furious & Fast Mystic Puristic Extended Gadget
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bs-rename-put-sbits-params.patch
Type: text/x-diff
Size: 598 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091129/26f2d68f/attachment.patch>