[FFmpeg-devel] [PATCH] MOV muxer : Add SoundDescriptionV2 support

[Michael Niedermayer]

On Sat, Nov 28, 2009 at 05:37:56PM +0530, Jai Menon wrote:
> On Sat, Nov 28, 2009 at 02:00:39AM -0800, Baptiste Coudurier wrote:
> > On 11/28/09 1:21 AM, Jai Menon wrote:
> > >On Sat, Nov 28, 2009 at 12:03:47AM -0800, Baptiste Coudurier wrote:
> > >>Hi,
> > >>
> > >>On 11/27/09 11:41 PM, Jai Menon wrote:
> > >
> > >[...]
> > >
> > >>>sounddescv2.patch
> > >>>
> > >>>
> > >>>diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > >>>index ac6378c..36b156e 100644
> > >>>--- a/libavformat/movenc.c
> > >>>+++ b/libavformat/movenc.c
> > >>>@@ -405,13 +405,21 @@ static int mov_write_glbl_tag(ByteIOContext *pb, MOVTrack *track)
> > >>>  static int mov_write_audio_tag(ByteIOContext *pb, MOVTrack *track)
> > >>>  {
> > >>>      int64_t pos = url_ftell(pb);
> > >>>-    int version = track->mode == MODE_MOV&&
> > >>>+    int version;
> > >>>+
> > >>>+    if (track->mode == MODE_MOV&&
> > >>>          (track->audio_vbr ||
> > >>>           track->enc->codec_id == CODEC_ID_PCM_S32LE ||
> > >>>-         track->enc->codec_id == CODEC_ID_PCM_S24LE);
> > >>>+         track->enc->codec_id == CODEC_ID_PCM_S24LE)) {
> > >>>+        if (track->timescale>   UINT16_MAX)
> > >>>+            version = 2;
> > >>
> > >>The stsd v2 must always be used when timescale>  UINT16_MAX
> > >>regardless of codec.
> > >
> > >Yes, I agree, but right now I just dont have the time required to make
> > >samples, remux and test against quicktime. Maybe someone who requires
> > >this for other codecs can add it later?
> > 
> > Well, by experience, half-baked solutions for specific codecs rot
> > forever in the codebase, so I would prefer avoiding it.
> 
> I don't think this is that big of a problem. The patch itself would be
> trivial since it requires setting version outside of the current if
> block -> ~2 line diff (unless I'm missing something). 

> The issue as I
> mentioned earlier is that I don't have a QT pro license so I dont
> have the freedom to generate and test against a multitude of samples.

id say skip the test then


> Also, there is the lack of time ;)

for testing i understand that but you still could make that ~2 line diff

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091128/240a8f56/attachment.pgp>