[FFmpeg-devel] [PATCH] lavdevice: SDL Audio Playback

[Diego Biurrun]

On Fri, Nov 27, 2009 at 05:38:41PM +0100, Ivo wrote:
> 
> The attached patch implements an SDL audio playback muxer in libavdevice. 
> Sadly, SDL does not support recording. In theory this should also enable 
> audio playback on windows/cygwin (not tested).

A documentation update is missing.

> --- /dev/null
> +++ b/libavdevice/sdl_audio.c
> @@ -0,0 +1,148 @@
> +static void sdl_audio_callback(void *opaque, Uint8 *stream, int len) {

K&R style for new files please.

> +av_cold static int audio_write_header(AVFormatContext *s1) {

I think it's "static av_cold" everywhere else, please check.

> +AVOutputFormat sdl_audio_muxer = {
> +    "sdl_audio",
> +    NULL_IF_CONFIG_SMALL("SDL Audio Playback"),
> +    "",
> +    "",
> +    sizeof(SdlAudioData),
> +#if HAVE_BIGENDIAN
> +    CODEC_ID_PCM_S16BE,
> +#else
> +    CODEC_ID_PCM_S16LE,
> +#endif

Maybe we should have S16NE for this?

Diego