[FFmpeg-devel] [PATCH] lavf: AVFMT_HAS_NONBLOCK flag for (de)muxers

[Luca Abeni]

Hi,

On Thu, 2009-11-26 at 18:08 +0100, Ivo wrote:
> On Thursday 26 November 2009, 18:06:33, Ivo wrote:
> > This patch...
[...]
>      while((res = snd_pcm_writei(s->h, buf, size / s->frame_size)) < 0) {
> -        if (res == -EAGAIN) {
> +        if (res == -EAGAIN && s1->flags & AVFMT_FLAG_NONBLOCK) {
>  
>              return AVERROR(EAGAIN);
>          }

Are you sure about this hunk? I would not expect alsa to return -EAGAIN
if the non-blocking flag has not been set previously...

Also, I think you said that the OSS driver is not honouring the NONBLOCK
flag... (or am I misremembering?). If this is the case, I suspect that
simply adding AVFMT_HAS_NONBLOCK to the oss_demuxer flags is not enough.
Or am I missing something?


	 		Thanks,
				Luca