[FFmpeg-devel] [RFC] Request for pixdesc API review

[Stefano Sabatini]

On date Tuesday 2009-11-24 19:02:17 -0500, Ronald S. Bultje encoded:
> Hi,
>
> On Nov, 2009, at 6:28 PM, Stefano Sabatini 
> <stefano.sabatini-lala at poste.it> wrote:
>> On date Monday 2009-11-23 22:44:57 +0100, Michael Niedermayer encoded:
>>> On Mon, Nov 23, 2009 at 09:48:49PM +0100, Stefano Sabatini wrote:
>> [...]
>>>> Index: ffmpeg/libavutil/pixdesc.h
>>>> ===================================================================
>>>> --- ffmpeg.orig/libavutil/pixdesc.h    2009-11-23  
>>>> 21:05:53.000000000 +0100
>>>> +++ ffmpeg/libavutil/pixdesc.h    2009-11-23 21:21:39.000000000  
>>>> +0100
>>>> @@ -86,7 +86,11 @@
>>>>
>>>> #define PIX_FMT_BE        1 ///< Pixel format is big-endian.
>>>> #define PIX_FMT_PAL       2 ///< Pixel format has a palette in data 
>>>> [1], values are indexes in this palette.
>>>> -#define PIX_FMT_BITSTREAM 4 ///< All values of a component are  
>>>> bit-wise packed end to end.
>>>> +/**
>>>> + * All values of a component are bit-wise packed end to end, that  
>>>> is,
>>>> + * the bits of the component values are not byte-aligned.
>>>
>>> i for one dont consider this better
>>
>> Well then I'd say patch dropped, unless someone else wants to suggest
>> something better.
>
> Data is not byte-aligned per pixel?

Yes per pixel they are, but not per pixel component.

Regards.
-- 
FFmpeg = Fantastic and Faithless Multimedia Patchable Encoding/decoding God