[FFmpeg-devel] [PATCH] Add pad filter

Stefano Sabatini stefano.sabatini-lala
Sun Nov 22 16:34:13 CET 2009

On date Monday 2009-11-09 00:39:26 +0100, Michael Niedermayer encoded:
> On Sun, Nov 08, 2009 at 09:50:13PM +0100, Stefano Sabatini wrote:
> > Hi,
> > 
> > this patch is not still ready for review, it is what I have in my
> > working tree, I'm publishing here as backup and for requesting some
> > comments.
> > 
> > TODO:
> > * remove normalizations
> > * add support for packed formats
> > 
> > What I like to be reviewed is the syntax, is OK to use
> > parseutils+expressions or it would be better just a simple:
> > 
> > w:h:x:y:color
> iam strongly in favor of the simplest thing possible so as not to hold
> the patch application up

sscanf + positional parameters, I'm not using expressions for now.

> > I believe expressions boost the filter flexibility, but I'll drop
> > their support if this will help to get the filter integrated sooner.
> i agree that expressions are a great thing that we definitly should support
> but i dont think the inital commit should

New patch attached.

I added support for RGB32 and RGB24 formats, it works fine but it
looks like the memcpy are quite slow, maybe someone can suggest how to
make them faster.

I'm not supporting YUV16 and RGB48 formats, that should be possible
with not too much effort but it could make the more common cases
slower, that and I'm not sure how to compute the color for these
formats (would a simple 16bit_color_val = 8bit_color_comp<<8 fit

FFmpeg = Fierce and Fundamental Mournful Problematic Erratic Ghost
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-pad-filter.patch
Type: text/x-diff
Size: 14661 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091122/743605d3/attachment.patch>

More information about the ffmpeg-devel mailing list