[FFmpeg-devel] [PATCH] als in mov

[Justin Ruggles]

Baptiste Coudurier wrote:

> On 11/21/09 7:19 PM, Justin Ruggles wrote:
>> Hi,
>>
>> This patch fixes muxing of MPEG-4 ALS in MOV.
>>
> 
> Can this be verified with any other decoder than lavc ?
> Does reference decoder works ?

The reference decoder does not support mov.

> Besides an object type to put in esds is needed, and which fourcc is used ?

'mp4a', same as aac.  and the object type is also the same as aac and is
already in ff_mp4_obj_type[].

>> [...]
>>
>> Index: libavformat/movenc.c
>> ===================================================================
>> --- libavformat/movenc.c	(revision 20571)
>> +++ libavformat/movenc.c	(working copy)
>> @@ -371,7 +371,8 @@
>>       put_tag(pb, "frma");
>>       put_le32(pb, track->tag);
>>
>> -    if (track->enc->codec_id == CODEC_ID_AAC) {
>> +    if (track->enc->codec_id == CODEC_ID_AAC ||
>> +        track->enc->codec_id == CODEC_ID_MP4ALS) {
>>           /* useless atom needed by mplayer, ipod, not needed by quicktime */
>>           put_be32(pb, 12); /* size */
>>           put_tag(pb, "mp4a");
>> @@ -452,7 +453,8 @@
>>           track->enc->codec_id == CODEC_ID_AMR_NB ||
>>           track->enc->codec_id == CODEC_ID_PCM_S24LE ||
>>           track->enc->codec_id == CODEC_ID_PCM_S32LE ||
>> -        track->enc->codec_id == CODEC_ID_ALAC))
>> +        track->enc->codec_id == CODEC_ID_ALAC ||
>> +        track->enc->codec_id == CODEC_ID_MP4ALS))
> 
> Avoid one line of diff by putting it before :)

indeed. new patch attached.

-Justin



-------------- next part --------------
A non-text attachment was scrubbed...
Name: mp4als_mov_2.patch
Type: text/x-diff
Size: 926 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091121/79eed939/attachment.patch>