[FFmpeg-devel] [PATCH] Use pkg-config for x264

[Carl Eugen Hoyos]

Felipe Contreras <felipe.contreras <at> gmail.com> writes:

> -enabled libx264  && require  libx264 x264.h x264_encoder_encode -lx264 -lm &&
> +enabled libx264  && add_cflags $(pkg-config --cflags x264) &&
> +    require  libx264 x264.h x264_encoder_encode $(pkg-config --libs x264) &&
>                        { check_cpp_condition x264.h "X264_BUILD >= 78" ||
>                          die "ERROR: libx264 version must be >= 0.78."; }
>  enabled libxvid    && require  libxvid xvid.h xvid_global -lxvidcore

Apart from the question which problem this fixes:
Wouldn't this break using a non-installed libx264 (which is currently no problem
with --extra-cflags and --extra-ldflags, iirc)?

Carl Eugen