[FFmpeg-devel] [PATCH] Update lix264.c for x264 API change (X264_BUILD 79)

Måns Rullgård mans
Sat Nov 21 20:01:16 CET 2009


Jason Garrett-Glaser <darkshikari at gmail.com> writes:

> On Fri, Nov 20, 2009 at 2:49 AM, Matthieu <mcrapet at gmail.com> wrote:
>> Grettings,
>
> At least do it right.  Forcing a perfectly good feature off is bad news.
>
> Index: libavcodec/avcodec.h
> ===================================================================
> --- libavcodec/avcodec.h	(revision 20562)
> +++ libavcodec/avcodec.h	(working copy)
> @@ -1197,7 +1197,16 @@
>  
>      int b_frame_strategy;
>  
> +#if LIBAVCODEC_VERSION_MAJOR < 53
>      /**
> +     * explicit weighted prediction analysis method
> +     * - encoding: Set by user.
> +     * - decoding: unused
> +     */
> +    int weighted_p_pred;
> +#endif

What's with the #if?  This breaks ABI.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list