[FFmpeg-devel] [FFMPEG] [PATCH] cavs encoder

[zhihang wang]

>
> > Index: libavcodec/mpegvideo_enc.c
> > ===================================================================
> > --- libavcodec/mpegvideo_enc.c        (revision 20541)
> > +++ libavcodec/mpegvideo_enc.c        (working copy)
> > @@ -366,7 +366,7 @@
> >          return -1;
> >      }
> >
> > -    if(s->quarter_sample && s->codec_id != CODEC_ID_MPEG4){
> > +    if(s->quarter_sample && s->codec_id != CODEC_ID_MPEG4 &&
> > s->codec_id != CODEC_ID_CAVS){
> >          av_log(avctx, AV_LOG_ERROR, "qpel not supported by codec\n");
> >          return -1;
> >      }
>
> I don't think this is necessary. Turning qpel off does not really make
> sense. We should ignore this option just like for H.264 encoding.
>
If we set the quarter_sample flag in the command line and the codec_id is
CAVS, I will cause *"qpel not supported by codec"* .
Is this ok?